refactor(pass-style): faster passStyleOf

[erights]

Closes: #XXXX
Refs: Agoric/agoric-sdk#10975 Agoric/agoric-sdk#10982

Description

Using the benchmark tool from #10975 by @muhammadahmadasifbhatti as modified by #10982 to produce flamegraphs (interactive in vscode) I iterated on that benchmark test which already had very specific simple examples exercising passStyleOf. Together with the snippet at https://github.com/Agoric/agoric-sdk/blob/acbb5da3c5a52bab8db319fd696aed70146f9a89/.github/actions/restore-node/action.yml#L156 (which @gibson042 brought to my attention)

$ scripts/get-packed-versions.sh ~/endo | scripts/resolve-versions.sh
$ yarn install && yarn build
$ cd packages/benchmark-test
$ yarn bench

and then clicking on the latest *.cpuprofile file, assuming you've already installed the https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-js-profile-flame vscode extension.

I was able to iterate and tinker on possible improvements, to see what made how much of a difference. This PR has the improvements to passStyleOf that I and my reviewers have came up with so far.

@gibson042 suggested the main technique used: to avoid redundant checking by breaking up assertValid so we could still running the checks of canBeValid twice.

Security Considerations

I claim that this PR is a pure refactoring. If true, none. Reviewers, please review with a skeptical eye. passStyleOf is security critical, so any observable difference might lead to an opportunity for an adversary.

Scaling Considerations

Even though I iterated on a specialized benchmark exercising passStyleOf, I believe I only made changes that would also be an improvement for the typical cases.

Documentation Considerations

If this is a pure refactor, none.

Testing Considerations

If this is a pure refactor, none. In fact, this PR did not need to change any tests, providing some weak evidence that it is indeed a pure refactor.

Compatibility Considerations

If this is a pure refactor, none.

Upgrade Considerations

If this is a pure refactor, none.

[erights]

Ready for review!