Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed spelling #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixed spelling #24

wants to merge 3 commits into from

Conversation

khushi-parikh
Copy link

this closes issue #23. please merge this under hacktoberfest.

@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for vibrant-goldberg-bb117d ready!

🔨 Explore the source changes: b2ce0c7

🔍 Inspect the deploy log: https://app.netlify.com/sites/vibrant-goldberg-bb117d/deploys/6169dee83356970007ff0d92

😎 Browse the preview: https://deploy-preview-24--vibrant-goldberg-bb117d.netlify.app

Copy link
Owner

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khushi-parikh. You also have to fix the spelling in the src/data/logos.js file.

Thanks

@khushi-parikh
Copy link
Author

@enjeck sorry that i missed it before, i have corrected it now.

Copy link
Owner

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more tiny change required

@@ -188,7 +188,7 @@ export const Logos = [
`Minimal professional black and white Ying Yang logo in square shape.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one here

@khushi-parikh
Copy link
Author

@enjeck changed 👍

Copy link
Owner

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now! Thanks!

@khushi-parikh
Copy link
Author

can it please be merged so that it can count in my contribution to hacktoberfest?

@enjeck
Copy link
Owner

enjeck commented Oct 15, 2021

@khushi-parikh Sure, I'll merge it later. For now, I'll add the hacktoberfest-accepted label.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants