This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: include widgets with 'form' selector #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyelidlessness
force-pushed
the
fix/textarea-resize
branch
from
e242fde to
30a0d0f
Compare
lognaturel
approved these changes
Aug 3, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes enketo/enketo#27. This affects the built-in textarea and radiopicker widgets, as well as any custom widgets with
selector: 'form'.Like #990, this would ideally have been caught by tests. But I feel more confident that this is a sufficient change to keep this particular optimization intact, with tests to come when we reintroduce the optimizations rolled back in #990.
We should also seriously consider not using/supporting a
'form'selector for widgets in general. To the extent it makes sense to have widget logic applied form-wide, we should have a design which addresses that separately fromselector.