Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix, remove or change to warning: false negatives for cyclic detection #47

Open
MartijnR opened this issue Feb 19, 2019 · 1 comment
Open

Comments

@MartijnR
Copy link
Member

False negatives:

  • using indexed-repeat() to get the value of the same node in a different repeat instance
  • using a predicate that includes ".", e.g. count(//text1[normalize-space(.)=“yes”])
@MartijnR
Copy link
Member Author

MartijnR commented Feb 21, 2019

I think this can be considered impossible to do properly (i.e. with actual errors). You'd have to run the form engine and detect infinite loops, because:

  1. self-references could be very complex via multiple nodes (but we could just leave that out)
  2. a calculation could refer to itself to e.g. determine its own ancestor repeat position within the form using indexed-repeat(). If we cannot exclude these false negatives, we'd have to perhaps output a "possible self-referencing warning" instead of an error

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant