Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Table.Offset #12071

Merged
merged 12 commits into from
Jan 21, 2025
Merged

Add Table.Offset #12071

merged 12 commits into from
Jan 21, 2025

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jan 17, 2025

Pull Request Description

Adds Table.Offset. Column.Offset to follow in next MR and also future MR for Fill_With.Constant

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley marked this pull request as ready for review January 17, 2025 21:34
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.
Like how simple the actual inner worker is.

@AdRiley AdRiley force-pushed the wip/adr/add-table-offset branch from d6eff53 to 327a4ee Compare January 20, 2025 20:34
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Jan 21, 2025
@AdRiley AdRiley merged commit a02cf2f into develop Jan 21, 2025
45 checks passed
@AdRiley AdRiley deleted the wip/adr/add-table-offset branch January 21, 2025 10:51
@AdRiley AdRiley removed the CI: Ready to merge This PR is eligible for automatic merge label Jan 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants