Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enabling native launchers for the release #12296

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 17, 2025

Pull Request Description

Let's finish #10121 by enabling native Enso launcher during the release builds.

Nightly release bits are built. Thanks for testing them.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before integrating, please remember to:

  • Manually schedule Nightly Release and download and test both Linux and Windows. I believe that Mac nightly release is still not working because of the signatures.
  • Probably also worth manually running Extra Nightly Tests

TL;DR; Make sure everything works before integration, as it might be too painful to fix it afterwards.

@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Feb 17, 2025

Nightly release bits are built:

Linux

ide-linux-amd64 - good I can execute ./enso-linux-x86_64-2025.1.1-nightly.2025.2.17.AppImage --no-sandbox and create and use new project. I can also:

$ ./enso-linux-x86_64-2025.1.1-nightly.2025.2.17.AppImage  --appimage-extract
$ ls -l ./squashfs-root/resources/enso/dist/2025.1.1-nightly.2025.2.17/bin/enso
495332456 ./squashfs-root/resources/enso/dist/2025.1.1-nightly.2025.2.17/bin/enso
$ ./squashfs-root/resources/enso/dist/2025.1.1-nightly.2025.2.17/bin/enso --run ~/fac.enso 30
265252859812191058636308480000000

e.g. the native image launcher is part of the AppImage and it works.

Windows

ide-windows-amd64 - good as well. Can create new project. Executing ~/AppData/Local/Programs/Enso/resources/enso/dist/2025.1.1-nightly.2025.2.17/bin/enso.exe works as well.

Thanks for testing them.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 17, 2025
@JaroslavTulach JaroslavTulach merged commit 3d6f2ec into develop Feb 17, 2025
63 of 67 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/EnableNative10121 branch February 17, 2025 21:38
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Feb 18, 2025

Nightly release with this PR in succeeded "as usual" these days: https://github.com/enso-org/enso/actions/runs/13381982489 - e.g. everything is OK except Mac build.

obrazek

Set ENSO_LAUNCHER=native environment variable before launching Enso application to opt-in.

Download Page

There is a download page and it offers enso-bundle - which seems to work on my Ubuntu:

$ tar fxvz enso-bundle-2025.1.1-nightly.2025.2.18-linux-amd64.tar.gz
$ ./enso/dist/2025.1.1-nightly.2025.2.18/bin/enso --run /enso/test/Table_Tests
5254 tests succeeded.
0 tests failed.
124 tests skipped.
36 groups skipped.

e.g. table tests can be executed in native mode.

@JaroslavTulach
Copy link
Member Author

@JaroslavTulach
Copy link
Member Author

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants