Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Table Visualization Fixes #1476

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Table Visualization Fixes #1476

merged 3 commits into from
Feb 15, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Feb 12, 2021

Pull Request Description

  1. Fixes column to vector conversions, such that it is a fast, non-copying operation.
  2. Introduces to_display API for use in the new default visualization to be created in the GUI.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement p-highest Should be completed ASAP labels Feb 12, 2021
@kustosz kustosz self-assigned this Feb 12, 2021
iamrecursion
iamrecursion approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!!

@kustosz kustosz merged commit 05945ed into main Feb 15, 2021
@kustosz kustosz deleted the wip/mk/table_vis_fixes branch February 15, 2021 08:55
iamrecursion pushed a commit that referenced this pull request Feb 15, 2021
@kustosz @iamrecursion
Table Visualization Fixes (#1476)
5758556
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@kustosz kustosz

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kustosz @iamrecursion