Invalidate Method Dependencies #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't understand how the provided test actually tests the scenario in #1510. It doesn't seem like you actually perform any edit of the code in the test, which would be good to perform if possible.
iamrecursion
approved these changes
Feb 25, 2021
iamrecursion
pushed a commit
that referenced
this pull request
Feb 26, 2021
When the edit changes the method body, invalidate all the method usages, and the corresponding dependencies
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1510
More careful dependency analysis. When the edit changes the method body, invalidate all the method usages (and the corresponding dependencies)
Important Notes
Checklist
Please include the following checklist in your PR: