Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make panic messages short #1528

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Make panic messages short #1528

merged 3 commits into from
Mar 1, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Feb 26, 2021 •
edited
Loading

Pull Request Description

Makes the java-facing string reps of panic exceptions short. These should not be visible in enso anyway, so this is
purely for logging / java-programmatic processing.

Closes #1527

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement p-highest Should be completed ASAP labels Feb 26, 2021
@kustosz kustosz self-assigned this Feb 26, 2021
@kustosz kustosz linked an issue Feb 26, 2021 that may be closed by this pull request
Backend crash when working with Enso #1527
Closed
@kustosz kustosz merged commit 3a88be5 into main Mar 1, 2021
@kustosz kustosz deleted the wip/mk/short-panic-message branch March 1, 2021 13:46
iamrecursion pushed a commit that referenced this pull request Mar 2, 2021
@kustosz @iamrecursion
Make panic messages short (#1528)
dc28192
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@kustosz kustosz

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend crash when working with Enso
2 participants
@kustosz @iamrecursion