Rank Suggestions by Self-Type Specificity #1629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR ensures that self-type suggestions are ranked by type specificity. This means that
Any
methods will show up last instead of first. If, for example, a search is done onInteger
, it will show methods onInteger
, then methods onNumber
, then methods onAny
.Closes #1627.
Important Notes
This is not the most efficient implementation as I can't work out how to use the slick DSL to encode the same logic inside the database query. That is a possible enhancement for the future.
Checklist
Please include the following checklist in your PR: