Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert GeoJSON to Table #1632

Merged
merged 14 commits into from
Mar 30, 2021
Merged

Convert GeoJSON to Table #1632

merged 14 commits into from
Mar 30, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Mar 29, 2021

Pull Request Description

close #1625
close #1626

PR adds to_table conversion of GeoJSON document into a dataframe.

Changelog:

  • feat: impl to_table method for GeoJSON format.
  • feat: impl Http.fetch method
  • refactor: Http library. Replace interfaces with union types

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-highest Should be completed ASAP labels Mar 29, 2021
@4e6 4e6 self-assigned this Mar 29, 2021
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify with @sylwiabr, but I think there's been a misunderstanding about converting a geo-JSON to a table.

@4e6
Copy link
Contributor Author

4e6 commented Mar 30, 2021

Update:

  • refactor Network module. Now methods are handling Panics and return appropriate Errors.
  • refactor Geojson module. Update existing to_table method to support GeoJSON format.

Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor cosmetic comment, but otherwise LGTM.

@iamrecursion iamrecursion merged commit 5cfd928 into main Mar 30, 2021
@iamrecursion iamrecursion deleted the wip/db/std-lib-update branch March 30, 2021 14:06
iamrecursion pushed a commit that referenced this pull request Apr 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fetch function to_table on geojson
3 participants