Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The user should be able to remove duplicate elements from a Vector #3224

Merged
merged 6 commits into from
Jan 17, 2022
Merged

The user should be able to remove duplicate elements from a Vector #3224

merged 6 commits into from
Jan 17, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jan 13, 2022 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jan 13, 2022
@radeusgd radeusgd changed the title A library developer should be able to select matching names given a list The user should be able to remove duplicate elements from a Vector Jan 14, 2022
@jdunkerley
Copy link
Member

Given the issues with Atom structural comparison we will need to mark one of the tests as pending but otherwise this looks good.

@radeusgd radeusgd force-pushed the wip/radeusgd/vector-distinct-180899205 branch from 2140ed8 to bef07c4 Compare January 14, 2022 10:25
@radeusgd radeusgd marked this pull request as ready for review January 14, 2022 10:26
@jdunkerley
Copy link
Member

LGTM 👍

@radeusgd radeusgd force-pushed the wip/radeusgd/vector-distinct-180899205 branch from 93a7b97 to 43dae19 Compare January 14, 2022 12:10
@4e6 4e6 merged commit 66082ea into develop Jan 17, 2022
@4e6 4e6 deleted the wip/radeusgd/vector-distinct-180899205 branch January 17, 2022 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@mwu-tow mwu-tow mwu-tow approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@radeusgd radeusgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radeusgd @jdunkerley @4e6 @mwu-tow