Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Windows CE support #211

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Remove Windows CE support #211

merged 1 commit into from
Jun 20, 2020

Conversation

forderud
Copy link
Contributor

@forderud forderud commented Jun 16, 2020

I don't think the Windows CE kernel is supported by Microsoft any more. The latest release was 8.0 in 2013 according to Wikipedia (https://en.wikipedia.org/wiki/Windows_Embedded_Compact).

Python 3.6 and newer also no longer support Windows CE (https://docs.python.org/3.6/library/os.html#os.name).

I recommend to "Hide whitespace changes" when reviewing this PR.
image

I don't think the Windows CE kernel is supported by Microsoft any more. The latest release was 8.0 in 2013 according to Wikipedia (https://en.wikipedia.org/wiki/Windows_Embedded_Compact).

Python 3.6 and newer also no longer support Windows CE (https://docs.python.org/3.6/library/os.html#os.name).
@vasily-v-ryabov
Copy link
Collaborator

Not sure this removal makes much sense. @cfarrow @jaraco are you aware about existing WinCE users?

@jaraco
Copy link
Collaborator

jaraco commented Jun 17, 2020

I'm not aware of any WinCE users, but that's not saying much. I agree it would be worthwhile to remove crufty code or at the very least abstract it away so it's not interleaved through the code.

Python 3.6 and newer also no longer support Windows CE (https://docs.python.org/3.6/library/os.html#os.name).

Is there a better reference describing the dropped support for Windows CE? Absence of a registered os.name seems inadequate.

I'm inclined to agree that it's unlikely this code is being used (or that CE users couldn't readily pin to older releases). Unless there's more information about active CE users, I'd recommend removing the functionality (with a backward-incompatible indication), but if there's a meaningful uproar as a result, consider reverting the change and restoring support.

@forderud
Copy link
Contributor Author

Quote from https://bugs.python.org/issue27355 :

Windows CE support never survived the transition to Python 3. It has clearly never even been compiled since Python 3.0 shipped.

@cfarrow
Copy link
Contributor

cfarrow commented Jun 17, 2020

I'm on the same page as @jaraco.

The risk of removing it is very low. The worst-case scenario is that a small number of users are inconvenienced and we learn who is using WinCE. The best case is that we go back to not worrying about who is using WinCE. :)

@vasily-v-ryabov vasily-v-ryabov merged commit 6fb4403 into enthought:master Jun 20, 2020
@forderud forderud deleted the win-ce-rm branch June 21, 2020 11:12
@wkschwartz
Copy link
Contributor

README still says CE is supported (I don't use CE, just happened to notice it)

junkmd pushed a commit that referenced this pull request Jun 7, 2024
Follow-up to #211 that dropped Windows CE support back in 2020. I doubt that any new comtypes user is interested in figuring out the last version that supported Windows CE these days. Therefore suggest removing the sentence from the front page since it's of low relevance.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants