Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update tests (style) #27

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Update tests (style) #27

merged 2 commits into from
Aug 12, 2022

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Aug 12, 2022 •
edited
Loading

Two stylistic updates to the existing tests:

  • Use subTest for tests in for loops
  • Apply black to the test module

Closes #25.

rahulporuri
rahulporuri approved these changes Aug 12, 2022
View reviewed changes
Copy link

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again. It looks like once #30 is merged and the changes pulled into this branch, CI should be happy.

@mdickinson
Copy link
Member Author

CI should be happy.

Let's find out! (Fingers crossed ...)

@mdickinson mdickinson merged commit 482a81f into main Aug 12, 2022
@mdickinson mdickinson deleted the update-tests branch August 12, 2022 13:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests should use subTest
2 participants
@mdickinson @rahulporuri