Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight cleanup of the
BaseFuture
and wrapper logic.Previously, when execution of the background task's callable was abandoned due to cancellation, we acted as though it had run anyway, sending a STARTED message followed by a RETURNED message (with an argument of None) to the future. That was slightly smelly (inventing a return result when none existed), and involved sending and processing two messages when one would have been sufficient.
This PR introduces a new ABANDONED message for this. It also:
CANCELLED
future state into three different internal states, depending on whether the task's callable completed, failed, or was never executed (abandoned)BaseFuture
to add explicit state changesThis PR is pure refactoring: it introduces no user-visible changes. The tests for the internals of the
BaseFuture
did need to be updated to take account of the extra message type. I'll self-merge after self-review.