deps: Update protbuf to v23.1

[yanavlasov]

New patches:

1. PGV to work with handling of new C++20 keywords added in protobuf (upstreaming change to PGV now)
2. absl patch to exclude stack symbolization for WASM modules. The implementation is buggy and causes existing WASM filter tests to fail. This is being fixed in emscripten SDK and absl env.emscripten_stack_snapshot not available in STANDALONE emscripten-core/emscripten#19753
3. Compilation issues in protobuf. Fixed on protbuf main, waiting for a new version to be cut

Breaking changes:

• Substitution formatter of the filter dynamic metadata no longer supports NaN and Inf floating point numbers, producing an error messages instead of JSON object of the proto. This is deemed to be an edge case.

Fixed a bunch of change detector tests that relied on specific error messages emitted by the previous version of the protobuf JSON parser.

Some dependencies are not at the bleeding edge versions, but this PR brings Envoy code over the biggest hump and allows to upgrade to newer version with smaller changes later.

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #27757

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #28075 was opened by yanavlasov.

see: more, trace.

[phlax]

patch looks good, thanks for working on this!

[yanavlasov]

Slow progress. Many dependencies are broken. Actively working on it.

[phlax]

possibly related protocolbuffers/protobuf#12523

(EDIT: probs not actually - i was trying to see what was going on with python headers)

[phlax]

re the python_headers im not sure we still need to alias them - but if we do i believe we can use

diff --git a/bazel/repositories.bzl b/bazel/repositories.bzl
index fd13e73479..ac50ff6276 100644
--- a/bazel/repositories.bzl
+++ b/bazel/repositories.bzl
@@ -894,7 +894,7 @@ def _com_google_protobuf():
     # https://github.com/google/protobuf/blob/v3.6.1/util/python/BUILD#L6-L9
     native.bind(
         name = "python_headers",
-        actual = "@com_google_protobuf//util/python:python_headers",
+        actual = "@system_python//:python_headers",
     )
 
 def _io_opencensus_cpp():

[yanavlasov]

There is still a ton of test failures due to a change to the error messages in protobuf JSON parser.

[yanavlasov]

Still about 15 tests are failing. Mobile build is broken for unknown reason. @RyanTheOptimist

[repokitteh-read-only]

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #28075 was synchronize by yanavlasov.

see: more, trace.

[alyssawilk]

Looks like this one is stalled. Did we decide to merge now or wait for release? If we're waiting let's tag it as such just to keep it off the daily on-call spam, and if not let's merge today to max out production time :-)

[phlax]

lgtm, thanks @yanavlasov

[phlax]

per offline discussion, landing

[phlax]

/coverage

[repokitteh-read-only]

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/28075/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

🐱

Caused by: a #28075 (comment) was created by @phlax.

see: more, trace.

[keith]

it doesn't look like this pgv patch ever made it upstream, sent it here bufbuild/protoc-gen-validate#1110