Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[enzyme-adapter-react-16] fix import #2047

Merged
merged 1 commit into from
Mar 13, 2019
Merged

[enzyme-adapter-react-16] fix import #2047

merged 1 commit into from
Mar 13, 2019

Conversation

doronpr
Copy link

@doronpr doronpr commented Mar 13, 2019

refs #2046

@zombieJ @ljharb
[enzyme-adapter-react-16] [fix] add an explicit .json extension
9b964a8 
Some folks with broken jest configurations were seeing "'react-test-renderer/package' not found".

Fixes enzymejs#2046
ljharb
ljharb previously requested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be broken. I’m importing the package.json, which absolutely works without an extension in node.

@ljharb
Copy link
Member

ljharb commented Mar 13, 2019

I've replaced this PR with the contents of #2048.

@ljharb ljharb merged commit 9b964a8 into enzymejs:master Mar 13, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb ljharb left review comments

Assignees
No one assigned
Labels
package: react adapter: 16 semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doronpr @ljharb @ramchoudhary @zombieJ