Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing minor bugs revealed while writing conda recipe #5

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Fixing minor bugs revealed while writing conda recipe #5

merged 6 commits into from
Sep 28, 2022

Conversation

elinscott
Copy link
Collaborator

This PR contains several minor bugfixes that were revealed in the process of writing a recipe for building koopmans-kcp with conda

@elinscott elinscott changed the title Minor bugfixes revealed when preparing for conda Minor bugfixes revealed while writing conda recipe Sep 21, 2022
@elinscott elinscott changed the title Minor bugfixes revealed while writing conda recipe Fixing minor bugs revealed while writing conda recipe Sep 21, 2022
@elinscott elinscott self-assigned this Sep 21, 2022
@elinscott elinscott requested a review from nscolonna September 22, 2022 14:00
@elinscott elinscott marked this pull request as ready for review September 23, 2022 13:43
nscolonna
nscolonna approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@nscolonna nscolonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm happy with this. Just have a look at my modifications to flib and maybe give it a try on your machine. Hope it's still working with conda

@elinscott
Copy link
Collaborator Author

I think I'm happy with this. Just have a look at my modifications to flib and maybe give it a try on your machine. Hope it's still working with conda

Thanks! The modifications look good, it compiles on my machine and works with conda. I will merge the PR!

@elinscott elinscott merged commit b33bcf9 into master Sep 28, 2022
@elinscott elinscott deleted the conda_bugfixes branch September 28, 2022 10:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nscolonna nscolonna nscolonna approved these changes

Assignees

@elinscott elinscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elinscott @nscolonna