Update to use pvi 0.8 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a Globals class for easier patching of paths for tests. Remove runtime generate path args and use patching in tests. Add verification of pvi template to motorSim test. Add directories for expected outputs of tests.
Following code assumes parsing succeeds and result has ioc_name, so check this to avoid obscure key errors. Any other issues will give a useful error when validation fails.
gilesknap
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
I actually like this sub-folder approach more - it is clearer what is going on as this file is really always called st.cmd
There was a problem hiding this comment.
I think this should be the new pattern for global config!
Comment on lines
+129
to
+132
| key: self.render( | ||
| context, template if template is not None else "{{ %s }}" % key | ||
| ) | ||
| for key, template in map.items() |
There was a problem hiding this comment.
Nicer than my deleted attempt from render_db.py
Comment on lines
+182
to
+189
| pv: bool = Field( | ||
| False, | ||
| description=( | ||
| "Whether to generate a PVI PV. This adds a database template with info " | ||
| "tags that create a PVAccess PV representing the device structure." | ||
| ), | ||
| ) | ||
| pv_prefix: str = Field("", description='PV prefix for PVI PV - e.g. "$(P)"') |
There was a problem hiding this comment.
this is also much clearer than the old pva thing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.