Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

switch to using MSI for db expansion #30

Merged
merged 2 commits into from
Jun 10, 2022
Merged

switch to using MSI for db expansion #30

merged 2 commits into from
Jun 10, 2022

Conversation

gilesknap
Copy link
Member

This PR adds the generation of an extra script in the ioc config folder called make_db.sh.

The script uses msi to do macro substitution for each 'database' entry in the ioc yaml and output an expanded database file.

@gilesknap
Copy link
Member Author

TODO: fix up the tests for the new scripts output

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #30 (2a8acfa) into main (d7a81fd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   97.87%   97.92%   +0.05%     
==========================================
  Files           8        8              
  Lines         329      338       +9     
==========================================
+ Hits          322      331       +9     
  Misses          7        7              
Impacted Files Coverage Δ
src/ibek/__main__.py 100.00% <100.00%> (ø)
src/ibek/helm.py 92.42% <100.00%> (+0.62%) ⬆️
src/ibek/render.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@gilesknap gilesknap merged commit 4fd8c8e into main Jun 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants