make schema check for missing non-defaulted args #93
+86
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where Args with no specified default were being allowed to not be supplied in the IOC schema. It should be a schema error if you supply no value in the IOC and the SUPPORT does not supply a default.
@coretl FYI
My mistake was removing default from the Support Arg types.
We do need default = None in the Support YAML so that IOCs can decide to specify defaults for Args.
But when we translate that into an IOC class we need to set default = PydanticUndefined where the instance of the Arg has default = None.