Rebased/fasrc fix onegate in oned conf #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to a typo, the onegate endpoint is currently always commented out. This behavior should be retained in the future, so adding a spec that describes the current behavior
This allows for setting the full onegate endpoint in oned.conf (needed if using https proxy, etc). If specified this param will override the onegate_ip param. Note this param does not change onegate conf, just the value of ONEGATE_ENDPOINT in oned.conf
workaround bug where hiera does not properly return undef
by removing the default to $::ipaddress we reinstate the old default behavior of not configuring any onegate endpoint if no explicit parameter is passed. Passing the ip-address as default can now be done by passing the fact as parameter. we also add a check that not both the onegate ip and the onegate endpoint are passed which would result in potentially confusing behavior.
Xylakant
force-pushed
the
rebased/fasrc-fix_onegate_in_oned_conf
branch
from
7c9c063 to
5ddea53
Compare
|
commit 3b99a5f changes behavior. Due to the typo, the condition never evaluated to true and the else path was always reached. I'll slot in a spec to demonstrate this behavior |
Xylakant
force-pushed
the
rebased/fasrc-fix_onegate_in_oned_conf
branch
from
5ddea53 to
a3bef23
Compare
Xylakant
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased version of #229
This still requires tests