Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: don't specify gift for a generic transaction type #201

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: don't specify gift for a generic transaction type #201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1997aea
fix: don't specify gift for a generic transaction type
iloveitaly Sep 17, 2023
519182f
Merge branch 'main' into less-specific-coinbase-out-guess
eprbell Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dali/plugin/input/rest/coinbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,8 @@ def _process_transfer(
asset=currency,
exchange=self.__COINBASE,
holder=self.account_holder,
transaction_type="Gift",
# could be a gift, payment to a 3rd party, etc but rp2 expects a type so we have to guess
transaction_type=Keyword.SELL.value,
spot_price=str(native_amount / amount),
crypto_out_no_fee=str(-amount),
crypto_fee="0",
Expand Down