Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

actions.yml: fix typo #136

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 21, 2024

GH Actions: add steps to view the output from the action

While these won't fail the build when the output isn't being generated, at the very least it should allow for visually verifying whether output is being generated.

actions.yml: fix typo

Output wasn't being generated for this action as there was a typo.

While these won't fail the build when the output isn't being generated, at the very least it should allow for visually verifying whether output is being generated.
Output wasn't being generated for this action as there was a typo.
Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon eps1lon merged commit 0bec9f3 into eps1lon:main Jan 6, 2025
@eps1lon
Copy link
Owner

eps1lon commented Jan 6, 2025

@eps1lon
Copy link
Owner

eps1lon commented Jan 6, 2025

Ideally we'd also document in README.md under a new section "Outputs"

@jrfnl jrfnl deleted the feature/action-yml-fix-typo branch January 6, 2025 11:59
@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 6, 2025

Ideally we'd also document in README.md under a new section "Outputs"

@eps1lon Thanks for merging this. And yes, documenting the output in the README would be great, but maybe it should be working first ?

While the outputs should now be available, based on the CI output, the output is not actually being created.

The description in the action.yml says it should be a "Object-map. The keys are pull request numbers and their values whether a PR is dirty or not.", but the output looks to be an empty object even though there is at least one open PR against the main branch which is currently dirty (#103) ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants