Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Restrict numpy to less than 2.0 #5899

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Restrict numpy to less than 2.0 #5899

merged 1 commit into from
Aug 17, 2023

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Aug 17, 2023 •
edited
Loading

This is in accordance with numpy/numpy#24300

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@eivindjahren eivindjahren added the release-notes:dependency Automatically categorise as dependency change in release notes label Aug 17, 2023
@eivindjahren eivindjahren changed the title Bound numpy to less than 2.0 Restrict numpy to less than 2.0 Aug 17, 2023
@eivindjahren eivindjahren self-assigned this Aug 17, 2023
kwinkunks
kwinkunks approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@eivindjahren eivindjahren merged commit 4e99b1a into main Aug 17, 2023
@eivindjahren eivindjahren deleted the set_numpy_bound branch August 17, 2023 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dafeda dafeda dafeda approved these changes

@kwinkunks kwinkunks kwinkunks approved these changes

Assignees

@eivindjahren eivindjahren

Labels
release-notes:dependency Automatically categorise as dependency change in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eivindjahren @kwinkunks @dafeda