Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix non-functional stackdates #329

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

berland
Copy link
Collaborator

@berland berland commented Jul 5, 2021

This fixes an ugly but that has been reported by an asset user, and probably warrants pushing into komodo asap.

The code that has been touched is apparently ugly, and could be a candidate for further refactoring.

@berland berland linked an issue Jul 5, 2021 that may be closed by this pull request
@berland berland requested review from asnyv and lindjoha July 5, 2021 13:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #329 (46a482b) into master (499b041) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 46a482b differs from pull request most recent head 4cf63c8. Consider uploading reports for the commit 4cf63c8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files          22       22           
  Lines        3025     3027    +2     
=======================================
+ Hits         2731     2733    +2     
  Misses        294      294           
Impacted Files Coverage Δ
ecl2df/grid.py 86.61% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499b041...4cf63c8. Read the comment docs.

@berland berland merged commit be46913 into equinor:master Jul 6, 2021
@berland berland deleted the fix_stackdates branch August 10, 2021 10:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grid] --stackdates drops data
3 participants