Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make things a bit less circular #470

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

yngve-sk
Copy link
Contributor

No description provided.

@yngve-sk yngve-sk force-pushed the remove-circular-imports-ffff branch 5 times, most recently from b40b911 to 5e00bfb Compare November 28, 2023 13:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b05c2e9) 95.17% compared to head (fafadda) 95.18%.

❗ Current head fafadda differs from pull request most recent head 5e00bfb. Consider uploading reports for the commit 5e00bfb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   95.17%   95.18%   +0.01%     
==========================================
  Files          31       32       +1     
  Lines        4413     4428      +15     
==========================================
+ Hits         4200     4215      +15     
  Misses        213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the remove-circular-imports-ffff branch 15 times, most recently from b5d8fa0 to 1a71ea6 Compare November 30, 2023 12:25
@yngve-sk yngve-sk force-pushed the remove-circular-imports-ffff branch from 1a71ea6 to 57133d0 Compare November 30, 2023 13:08
@jonathan-eq jonathan-eq self-requested a review December 1, 2023 07:01
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good job!

@yngve-sk yngve-sk merged commit 8fa3b8f into master Dec 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants