Expect RuntimeError or ValueError in ntequl test #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 33 33
Lines 4461 4461
=======================================
Hits 4246 4246
Misses 215 215 ☔ View full report in Codecov by Sentry. |
|
I can't merge this myself -- #471 is also for Python 3.11 😄 |
Later versions of opm use a newer pybind11 version and potentially different exceptions for input errors in its C++ backend. This makes both `RuntimeError` and `ValueError` possible but tricky to pin down to a particular opm version. This takes the easy route and allows for both.
mferrera
force-pushed
the
fix-ntequl-test
branch
from
054ef9e to
57e58b9
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Python 3.11+ support
Later versions of opm use a newer pybind11 version and potentially different exceptions for input errors in its C++ backend. This makes both
RuntimeErrorandValueErrorpossible but tricky to pin down to a particular opm version. This takes the easy route and allows for both.