Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(scheduler): sync instance info memory leak #1485

Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix(scheduler): sync instance info memory leak #1485

merged 1 commit into from
Aug 18, 2021

Conversation

Muzry
Copy link
Contributor

@Muzry Muzry commented Aug 17, 2021

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

  • fix(scheduler): sync instance info memory leak

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily @sixther-dc

ChangeLog

Language Changelog
🇺🇸 English fix(scheduler): sync instance info memory leak
🇨🇳 中文 修复获取实例列表内存泄漏的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested review from luobily and sixther-dc August 17, 2021 11:06
@Muzry Muzry added bugfix orchestrator workload management labels Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #1485 (c737b7b) into master (f74c0e4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   12.17%   12.18%           
=======================================
  Files        1007     1007           
  Lines      105142   105143    +1     
=======================================
+ Hits        12805    12807    +2     
+ Misses      91138    91137    -1     
  Partials     1199     1199           
Impacted Files Coverage Δ
modules/scheduler/executor/plugins/k8s/k8s.go 1.43% <ø> (+0.31%) ⬆️

Copy link
Contributor

@sixther-dc sixther-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sfwn
Copy link
Member

sfwn commented Aug 18, 2021

/approve

@erda-bot erda-bot merged commit 80e0d74 into erda-project:master Aug 18, 2021
@Muzry
Copy link
Contributor Author

Muzry commented Aug 18, 2021

/cherry-pick release/1.2

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants