Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: add the User-ID of header for gittar bundle #1663

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

littlejiancc
Copy link
Contributor

@littlejiancc littlejiancc commented Sep 3, 2021

What type of this PR

/kind feature

What this PR does / why we need it:

feature: add the User-ID of header for gittar bundle

Which issue(s) this PR fixes:

调用gittar的bundle都需要加上User-ID验证

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English add the User-ID of header for gittar bundle
🇨🇳 中文 调用gittar的bundle都需要加上User-ID验证

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn September 3, 2021 06:12
@littlejiancc littlejiancc added gittar dop devops plaoform orchestrator workload management labels Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1663 (41ecc7b) into master (1049911) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   13.43%   13.43%   -0.01%     
==========================================
  Files        1083     1083              
  Lines      111379   111397      +18     
==========================================
+ Hits        14962    14964       +2     
- Misses      95018    95033      +15     
- Partials     1399     1400       +1     
Impacted Files Coverage Δ
apistructs/event.go 100.00% <ø> (ø)
modules/dop/endpoints/branch_rule.go 0.00% <0.00%> (ø)
modules/dop/endpoints/filetree.go 0.00% <0.00%> (ø)
modules/dop/endpoints/pipeline.go 3.40% <0.00%> (+0.10%) ⬆️
modules/dop/endpoints/projectpipelinefiletree.go 0.00% <0.00%> (ø)
modules/dop/endpoints/release.go 0.00% <0.00%> (ø)
modules/dop/endpoints/snippet.go 11.34% <0.00%> (ø)
modules/dop/services/pipeline/pipeline.go 2.57% <0.00%> (ø)
modules/orchestrator/endpoints/runtime.go 0.00% <0.00%> (ø)
modules/orchestrator/services/runtime/runtime.go 7.23% <0.00%> (ø)
... and 2 more

@littlejiancc littlejiancc changed the title feature: add the user-id of header for gittar bundle feature: add the User-ID of header for gittar bundle Sep 3, 2021
@sfwn
Copy link
Member

sfwn commented Sep 6, 2021

/approve

@erda-bot erda-bot merged commit 5e148bb into erda-project:master Sep 6, 2021
@littlejiancc littlejiancc deleted the feature/gittar-bundle branch September 24, 2021 10:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved dop devops plaoform gittar orchestrator workload management
Development

Successfully merging this pull request may close these issues.

3 participants