Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix imported autotest config sheet display outputs error #2609

Merged

Conversation

chengjoey
Copy link
Member

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

fix config sheet that created by imported excel display error

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey force-pushed the fix/autotest-configsheet-outputs-error branch from ab92efe to 3e732ba Compare October 27, 2021 09:53
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2609 (3e732ba) into master (1cc6798) will increase coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2609      +/-   ##
==========================================
+ Coverage   16.39%   16.41%   +0.01%     
==========================================
  Files        1255     1259       +4     
  Lines      127508   127706     +198     
==========================================
+ Hits        20909    20961      +52     
- Misses     104454   104581     +127     
- Partials     2145     2164      +19     
Impacted Files Coverage Δ
...os/auto-test-scenes/components/apiEditor/render.go 0.00% <0.00%> (ø)
...api/component-protocol/pkg/autotest/step/output.go 78.76% <50.00%> (-2.06%) ⬇️
modules/admin/manager/cluster.go 13.41% <0.00%> (-0.10%) ⬇️
...protocol/components/test-dashboard/filter/model.go 0.00% <0.00%> (ø)
...tocol/components/test-dashboard/filter/provider.go 66.66% <0.00%> (ø)
modules/admin/manager/permission.go 78.57% <0.00%> (ø)
...rotocol/components/test-dashboard/filter/render.go 6.30% <0.00%> (ø)
modules/admin/manager/id.go 70.58% <0.00%> (+70.58%) ⬆️

@sfwn
Copy link
Member

sfwn commented Oct 27, 2021

/approve

@erda-bot erda-bot merged commit 1e18544 into erda-project:master Oct 27, 2021
@sfwn
Copy link
Member

sfwn commented Oct 27, 2021

/cherry-pick release/1.4

erda-bot added a commit that referenced this pull request Oct 27, 2021
Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/autotest-configsheet-outputs-error branch November 15, 2021 08:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

3 participants