Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(dop): Solve the problem of broken link caused by adding scenes #4024

Merged

Conversation

littlejiancc
Copy link
Contributor

What this PR does / why we need it:

Solve the problem of broken link caused by adding scenes

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English Solve the problem of broken link caused by adding scenes
🇨🇳 中文 解决添加场景引起的断链问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added bugfix dop devops plaoform labels Feb 11, 2022
@erda-bot erda-bot requested a review from sfwn February 11, 2022 11:21
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #4024 (f6ac08d) into master (6fc8682) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4024   +/-   ##
=======================================
  Coverage   19.10%   19.10%           
=======================================
  Files        1475     1475           
  Lines      155051   155059    +8     
=======================================
+ Hits        29616    29620    +4     
- Misses     122452   122458    +6     
+ Partials     2983     2981    -2     
Impacted Files Coverage Δ
modules/dop/services/autotest_v2/scene.go 0.00% <0.00%> (ø)
...omponents/cmp-dashboard-nodes/nodeFilter/render.go 49.33% <0.00%> (ø)
modules/dop/services/issue/issue.go 4.28% <0.00%> (+0.38%) ⬆️

@sfwn
Copy link
Member

sfwn commented Feb 11, 2022

/approve

@erda-bot erda-bot merged commit c373771 into erda-project:master Feb 11, 2022
@littlejiancc littlejiancc deleted the feature/dop-autotest-scene branch March 29, 2022 02:57
@littlejiancc
Copy link
Contributor Author

/cherry-pick release/1.5

@littlejiancc littlejiancc restored the feature/dop-autotest-scene branch April 22, 2022 03:02
@littlejiancc
Copy link
Contributor Author

/cherry-pick release/1.5

@erda-bot
Copy link
Member

Automated cherry pick failed, please resolve the confilcts and create PR manually.
Details:

Auto-merging go.mod
Auto-merging go.sum
Auto-merging modules/dop/component-protocol/scenarios/auto-test-scenes.yml
Auto-merging modules/dop/services/autotest_v2/scene.go
[auto-cherry-pick-pr/release-1.5-4024 2828a1fc2] fix: Solve the problem of broken link caused by adding scenes (#4024)
 Author: littlejian <17816869670@163.com>
 Date: Fri Feb 11 20:35:15 2022 +0800
 2 files changed, 14 insertions(+), 1 deletion(-)

@erda-bot
Copy link
Member

Automated cherry pick failed, please resolve the confilcts and create PR manually.
Details:

Auto-merging go.mod
Auto-merging go.sum
Auto-merging modules/dop/component-protocol/scenarios/auto-test-scenes.yml
Auto-merging modules/dop/services/autotest_v2/scene.go
[auto-cherry-pick-pr/release-1.5-4024 dfdb799c7] fix: Solve the problem of broken link caused by adding scenes (#4024)
 Author: littlejian <17816869670@163.com>
 Date: Fri Feb 11 20:35:15 2022 +0800
 2 files changed, 14 insertions(+), 1 deletion(-)

erda-bot added a commit that referenced this pull request Apr 22, 2022
@littlejiancc littlejiancc deleted the feature/dop-autotest-scene branch June 10, 2022 06:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants