Enhancement: Implement BuildMetaData
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=============================================
- Coverage 100.00% 96.63% -3.37%
- Complexity 37 47 +10
=============================================
Files 10 12 +2
Lines 95 119 +24
=============================================
+ Hits 95 115 +20
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. |
localheinz
force-pushed
the
feature/build-meta-data
branch
from
e2bf29d to
8d189ae
Compare
localheinz
commented
Dec 25, 2023
| @@ -48,12 +49,22 @@ public static function fromString(string $value): self | |||
| $preRelease = PreRelease::fromString($matches['prerelease']); | |||
| } | |||
|
|
|||
| $buildMetaData = BuildMetaData::empty(); | |||
There was a problem hiding this comment.
To avoid using
null- nullable fields
- nullable return types
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
BuildMetaDataas a value object