Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

upgrade lib-p2p: there is breaking change - changed mux #8078

Closed
AskAlexSharov opened this issue Aug 25, 2023 · 2 comments · Fixed by #8288
Closed

upgrade lib-p2p: there is breaking change - changed mux #8078

AskAlexSharov opened this issue Aug 25, 2023 · 2 comments · Fixed by #8288

Comments

@AskAlexSharov
Copy link
Collaborator

No description provided.

This was referenced Aug 25, 2023
Closed
Closed
@RatanRSur
Copy link

still seeing the go related issue blocked by this. Any workarounds for now?

@AskAlexSharov
Copy link
Collaborator Author

Use go1.20

@jyellick jyellick mentioned this issue Sep 25, 2023
Merged
Giulio2002 pushed a commit that referenced this issue Sep 29, 2023
@jyellick
Upgrade libp2p (enables go 1.21 support) (#8288)
5654ba0 
Closes #8078 

This change is primarily intended to support go 1.21, but as a
side-effect requires updating libp2p, which in turn triggers an update
of golang.org/x/exp which creates quite a bit of (simple) churn in the
slice sorting.

This change introduces a new `cmp.Compare` function which can be used to
return an integer satisfying the compare interface for slice sorting.

In order to continue to support mplex for libp2p, the change references
github.com/libp2p/go-libp2p-mplex instead. Please see the PR at
libp2p/go-libp2p#2498 for the official usptream
comment that indicates official support for mplex being moved to this
location.

Co-authored-by: Jason Yellick <jason@enya.ai>
lemenkov pushed a commit to lemenkov/erigon that referenced this issue Oct 2, 2023
@jyellick @lemenkov
Upgrade libp2p (enables go 1.21 support) (erigontech#8288)
408dc14 
Closes erigontech#8078 

This change is primarily intended to support go 1.21, but as a
side-effect requires updating libp2p, which in turn triggers an update
of golang.org/x/exp which creates quite a bit of (simple) churn in the
slice sorting.

This change introduces a new `cmp.Compare` function which can be used to
return an integer satisfying the compare interface for slice sorting.

In order to continue to support mplex for libp2p, the change references
github.com/libp2p/go-libp2p-mplex instead. Please see the PR at
libp2p/go-libp2p#2498 for the official usptream
comment that indicates official support for mplex being moved to this
location.

Co-authored-by: Jason Yellick <jason@enya.ai>
lemenkov pushed a commit to fedora-ethereum/erigon that referenced this issue Oct 4, 2023
@jyellick @lemenkov
Upgrade libp2p (enables go 1.21 support) (erigontech#8288)
e953638 
Closes erigontech#8078 

This change is primarily intended to support go 1.21, but as a
side-effect requires updating libp2p, which in turn triggers an update
of golang.org/x/exp which creates quite a bit of (simple) churn in the
slice sorting.

This change introduces a new `cmp.Compare` function which can be used to
return an integer satisfying the compare interface for slice sorting.

In order to continue to support mplex for libp2p, the change references
github.com/libp2p/go-libp2p-mplex instead. Please see the PR at
libp2p/go-libp2p#2498 for the official usptream
comment that indicates official support for mplex being moved to this
location.

Co-authored-by: Jason Yellick <jason@enya.ai>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade libp2p (enables go 1.21 support) bobanetwork/op-erigon
2 participants
@RatanRSur @AskAlexSharov