Add ability to specify OTP architecture #316
Merged
+101
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM. Would like to see what @paulo-ferraz-oliveira . |
wojtekmach
reviewed
Jan 18, 2025
|
@starbelly do you think the failing check is some transient issue with builds.hex.pm? Would you be able to rerun it? |
That indeed was the issue. This LGTM and @wojtekmach seemed to think so as well. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #315 .
n.b. I have checked
npm testand it is returning an exit code of 0, but there is a massive amount of debug output so I could not see any success/fail messages from testing.