pythongh-104614: Fix potential ref. leak in _testcapimodule/get_basic…

…_static_type()
erlend-aasland · Jun 2, 2023 · 5319302 · 5319302
1 parent ee26ca1
commit 5319302
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
@@ -2671,13 +2671,15 @@ get_basic_static_type(PyObject *self, PyObject *args)
     PyTypeObject *cls = &BasicStaticTypes[num_basic_static_types_used++];
 
     if (base != NULL) {
-        cls->tp_base = (PyTypeObject *)Py_NewRef(base);
         cls->tp_bases = Py_BuildValue("(O)", base);
         if (cls->tp_bases == NULL) {
             return NULL;
         }
+        cls->tp_base = (PyTypeObject *)Py_NewRef(base);
     }
     if (PyType_Ready(cls) < 0) {
+        Py_DECREF(cls->tp_bases);
+        Py_DECREF(cls->tp_base);
         return NULL;
     }
     return (PyObject *)cls;