Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cli-color, chalk #149

Closed
benmccann opened this issue Aug 17, 2024 · 3 comments · Fixed by #188
Closed

cli-color, chalk #149

benmccann opened this issue Aug 17, 2024 · 3 comments · Fixed by #188

Comments

@benmccann
Copy link
Contributor

In the short-term, replace with picocolors, kleur, etc.

Maybe starting in April 2025 when Node 18 is EOL consider replacing with styleText

@43081j
Copy link
Contributor

43081j commented Aug 18, 2024

I think it makes sense. We can list all 3 if we don't already (I think there might already be a chalk entry, so we might just need to update)

@Lehoczky
Copy link
Contributor

Lehoczky commented Aug 22, 2024

There was a previous discussion about chalk specifically: #17

I'm still interested to see how yoctocolors fare against other alternatives, as it claims to be the fastest and smallest of the bunch.

Edit: it might also worth considering that styleText has a clunky API compared to non-native alternatives so it might not be that good of a replacement: https://bjornlu.com/blog/im-tired-of-node-builtin-apis#styletext

@43081j
Copy link
Contributor

43081j commented Aug 22, 2024

i'm hesitant to add yoctocolors since it offers no benefit over picocolors and is near enough a copy-paste of the same logic but slower in some cases

it isn't smaller, picocolors is (pc 5KB vs yc 10KB)
it isn't faster, picocolors and ansis are (each in different situations)

if we start adding alternatives that don't have anything to offer over the established ones, we'll just confuse users with too many choices. this needs to stay a well curated list rather than a bucket of "stuff"

styleText does seem in very early stages still. its nice to recommend but we should note that it is far from 'final'

43081j added a commit that referenced this issue Dec 6, 2024
Adds `chalk` and `cli-color` to the preferred manifest and documents alternatives.

Closes #149
@43081j 43081j closed this as completed in 4d372d0 Dec 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants