Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue with build and deploy #128

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix issue with build and deploy #128

merged 1 commit into from
Jan 15, 2025

Conversation

fnattino
Copy link
Collaborator

Ubuntu 24 comes with no R installed, fix issues with GH action by pinning Ubuntu 22.

Applying this fix: https://github.com/carpentries/sandpaper/pull/606/files

See issue: carpentries/sandpaper#605

Copy link

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/workflows/sandpaper-main.yaml

If this is not from a trusted source, please inspect the changes for any malicious content.

@fnattino
Copy link
Collaborator Author

Copy link
Collaborator

@rogerkuou rogerkuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! sorry overlooked when reviewing #129.
Just one small remark, maybe let's document this pinning somewhere (like an issue) and revisit this later (in a year)? Maybe ubuntun 24 machine will have R at that time.

@fnattino fnattino merged commit 856842c into main Jan 15, 2025
3 checks passed
@fnattino fnattino deleted the fix-build-and-deploy branch January 15, 2025 10:04
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
Auto-generated via `{sandpaper}`
Source  : 856842c
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy

Fix issue with build and deploy
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
Auto-generated via `{sandpaper}`
Source  : a3471f8
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-15 10:06:15 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 856842c
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy

Fix issue with build and deploy
github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
Auto-generated via `{sandpaper}`
Source  : a3471f8
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-15 10:06:15 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 856842c
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy

Fix issue with build and deploy
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
Auto-generated via `{sandpaper}`
Source  : a3471f8
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-15 10:06:15 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 856842c
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy

Fix issue with build and deploy
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
Auto-generated via `{sandpaper}`
Source  : a3471f8
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-15 10:06:15 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 856842c
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy

Fix issue with build and deploy
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Auto-generated via `{sandpaper}`
Source  : a3471f8
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-15 10:06:15 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 856842c
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy

Fix issue with build and deploy
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants