Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updating README.md #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updating README.md #32

wants to merge 3 commits into from

Conversation

CalvinRodo
Copy link
Member

Added status badges
Added information for running tests
Removed info for running tests from GUI Section

Added status badges
Added information for running tests
Removed info for running tests from GUI Section
@CalvinRodo CalvinRodo requested a review from s-laugh March 14, 2019 19:15
Copy link
Member

@s-laugh s-laugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the main sections doesn't seem logical. Tests, then running everything in docker, then specially the GUI, and nothing specific for the API.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Run the following command to test the app in electron headless mode
```
npx cypress run
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I was actually able to get this running do to missing dependencies https://docs.cypress.io/guides/guides/continuous-integration.html#Advanced-setup
It's still gives me errors because it can't connect to http://localhost:4848 - I'm guessing the app needs to be run in docker first to run the test, so that should be mentioned here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the readme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you push your change, i don't see it...

@CalvinRodo CalvinRodo requested a review from s-laugh March 15, 2019 17:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants