-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updating README.md #32
base: master
Are you sure you want to change the base?
Conversation
Added status badges Added information for running tests Removed info for running tests from GUI Section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of the main sections doesn't seem logical. Tests, then running everything in docker, then specially the GUI, and nothing specific for the API.
Run the following command to test the app in electron headless mode | ||
``` | ||
npx cypress run | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I was actually able to get this running do to missing dependencies https://docs.cypress.io/guides/guides/continuous-integration.html#Advanced-setup
It's still gives me errors because it can't connect to http://localhost:4848 - I'm guessing the app needs to be run in docker first to run the test, so that should be mentioned here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you push your change, i don't see it...
Added status badges
Added information for running tests
Removed info for running tests from GUI Section