Remove more dead code

[NelsonVides]

Just a quick run of https://github.com/AdRoll/rebar3_hank killing a bit of dead code.
Also improved some code in mongoose_iq_handler 😉

[mongoose-im]

small_tests_23 / small_tests / a2d5471
Reports root / small

---

small_tests_24 / small_tests / a2d5471
Reports root / small

---

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / a2d5471
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a2d5471
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / a2d5471
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_24 / mysql_redis / a2d5471
Reports root/ big
OK: 2709 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / a2d5471
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0

---

ldap_mnesia_23 / ldap_mnesia / a2d5471
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0

---

internal_mnesia_24 / internal_mnesia / a2d5471
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0

---

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a2d5471
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / a2d5471
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

---

pgsql_mnesia_23 / pgsql_mnesia / a2d5471
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

---

mysql_redis_24 / mysql_redis / a2d5471
Reports root/ big
OK: 3108 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

---

mssql_mnesia_24 / odbc_mssql_mnesia / a2d5471
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

---

riak_mnesia_24 / riak_mnesia / a2d5471
Reports root/ big
OK: 1726 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

[codecov]

Codecov Report

Merging #3451 (a2d5471) into master (394ec28) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3451      +/-   ##
==========================================
- Coverage   80.85%   80.81%   -0.05%     
==========================================
  Files         415      415              
  Lines       32312    32312              
==========================================
- Hits        26125    26112      -13     
- Misses       6187     6200      +13     

Impacted Files	Coverage Δ
src/admin_extra/service_admin_extra_upload.erl	93.75% <ø> (ø)
src/amp_strategy.erl	95.65% <ø> (ø)
src/domain/service_domain_db.erl	83.33% <ø> (ø)
src/ejabberd.erl	60.00% <ø> (ø)
src/ejabberd_sm.erl	84.59% <ø> (ø)
src/mam/mod_mam_cassandra_arch.erl	84.61% <ø> (ø)
src/mam/mod_mam_muc_cassandra_arch.erl	84.54% <ø> (ø)
src/mam/mod_mam_riak_timed_arch_yz.erl	86.81% <ø> (ø)
src/mod_csi.erl	100.00% <ø> (ø)
src/mod_keystore.erl	89.09% <ø> (ø)
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394ec28...a2d5471. Read the comment docs.

[arcusfelis]

ok