Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convert mod_carboncopy to use maps as options #3602

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Convert mod_carboncopy to use maps as options #3602

merged 1 commit into from
Mar 23, 2022

Conversation

arcusfelis
Copy link
Contributor

No description provided.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 22, 2022 •
edited
Loading

small_tests_24 / small_tests / 1d2c345
Reports root / small

small_tests_23 / small_tests / 1d2c345
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 1d2c345
Reports root/ big
OK: 2824 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1d2c345
Reports root/ big
OK: 2824 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 1d2c345
Reports root/ big
OK: 2807 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 1d2c345
Reports root/ big
OK: 2824 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 1d2c345
Reports root/ big
OK: 1505 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 1d2c345
Reports root/ big
OK: 1505 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 1d2c345
Reports root/ big
OK: 1546 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 1d2c345
Reports root/ big
OK: 3198 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 1d2c345
Reports root/ big
OK: 3198 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 1d2c345
Reports root/ big
OK: 1853 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 1d2c345
Reports root/ big
OK: 3193 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 1d2c345
Reports root/ big
OK: 3198 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 1d2c345
Reports root/ big
OK: 1696 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #3602 (940596c) into master (a9c68bd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   80.89%   80.89%   -0.01%     
==========================================
  Files         426      426              
  Lines       32250    32250              
==========================================
- Hits        26090    26088       -2     
- Misses       6160     6162       +2
Impacted Files Coverage Δ
src/mod_carboncopy.erl 88.40% <100.00%> (ø)
src/inbox/mod_inbox.erl 87.42% <0.00%> (-1.72%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/inbox/mod_inbox_rdbms.erl 93.12% <0.00%> (-0.63%) ⬇️
src/mod_muc_room.erl 76.70% <0.00%> (-0.18%) ⬇️
src/mod_muc_log.erl 63.21% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.07% <0.00%> (+0.18%) ⬆️
src/domain/mongoose_domain_loader.erl 90.17% <0.00%> (+0.89%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 68.88% <0.00%> (+2.22%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 85.71% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c68bd...940596c. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 22, 2022 •
edited
Loading

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 8c195a1
Reports root

pgsql_mnesia_23 / pgsql_mnesia / 8c195a1
Reports root

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8c195a1
Reports root

ldap_mnesia_24 / ldap_mnesia / 8c195a1
Reports root

pgsql_mnesia_24 / pgsql_mnesia / 8c195a1
Reports root

internal_mnesia_24 / internal_mnesia / 8c195a1
Reports root

ldap_mnesia_23 / ldap_mnesia / 8c195a1
Reports root

mssql_mnesia_24 / odbc_mssql_mnesia / 8c195a1
Reports root

riak_mnesia_24 / riak_mnesia / 8c195a1
Reports root

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 8c195a1
Reports root

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 8c195a1
Reports root

small_tests_23 / small_tests / 8c195a1
Reports root / small

small_tests_24 / small_tests / 8c195a1
Reports root / small

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 22, 2022 •
edited
Loading

small_tests_24 / small_tests / 940596c
Reports root / small

small_tests_23 / small_tests / 940596c
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 940596c
Reports root/ big
OK: 2824 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 940596c
Reports root/ big
OK: 2824 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 940596c
Reports root/ big
OK: 2807 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 940596c
Reports root/ big
OK: 2824 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 940596c
Reports root/ big
OK: 1505 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 940596c
Reports root/ big
OK: 1546 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 940596c
Reports root/ big
OK: 3198 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 940596c
Reports root/ big
OK: 3198 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 940596c
Reports root/ big
OK: 1853 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 940596c
Reports root/ big
OK: 3193 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 940596c
Reports root/ big
OK: 3198 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 940596c
Reports root/ big
OK: 1696 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

NelsonVides
NelsonVides reviewed Mar 23, 2022
View reviewed changes
src/mod_carboncopy.erl Outdated
Comment on lines 77 to 79
start(HostType, Opts) ->
%% execute disable/enable actions in the c2s process itself
IQDisc = gen_mod:get_opt(iqdisc, Opts, no_queue),
%% Default no_queue - executes disable/enable actions in the c2s process itself
IQDisc = gen_mod:get_opt(iqdisc, Opts),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe match on the iqdisc on the start function head?

@arcusfelis arcusfelis force-pushed the mu-cc-map-options branch 2 times, most recently from 1200d98 to 87549c4 Compare March 23, 2022 15:13
chrzaszcz
chrzaszcz approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit b6da9a9 into master Mar 23, 2022
@chrzaszcz chrzaszcz deleted the mu-cc-map-options branch March 23, 2022 15:41
@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 23, 2022 •
edited
Loading

small_tests_24 / small_tests / 374bf1f
Reports root / small

small_tests_23 / small_tests / 374bf1f
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 374bf1f
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 374bf1f
Reports root/ big
OK: 2809 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 374bf1f
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 374bf1f
Reports root/ big
OK: 1507 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 374bf1f
Reports root/ big
OK: 1507 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 374bf1f
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 374bf1f
Reports root/ big
OK: 1548 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 374bf1f
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 374bf1f
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 374bf1f
Reports root/ big
OK: 1855 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 374bf1f
Reports root/ big
OK: 3195 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 374bf1f
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 374bf1f
Reports root/ big
OK: 1698 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NelsonVides NelsonVides NelsonVides left review comments

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@arcusfelis @mongoose-im @chrzaszcz @NelsonVides @Premwoik