Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

No need to enforce successful execute in the inbox bin cleanups #3670

Merged
merged 1 commit into from
Jun 6, 2022
Merged

No need to enforce successful execute in the inbox bin cleanups #3670

merged 1 commit into from
Jun 6, 2022

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #3670 (0a9296f) into master (9a83e02) will increase coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
+ Coverage   81.14%   81.16%   +0.01%     
==========================================
  Files         433      433              
  Lines       31909    31912       +3     
==========================================
+ Hits        25893    25900       +7     
+ Misses       6016     6012       -4
Impacted Files Coverage Δ
src/inbox/mod_inbox_rdbms.erl 92.09% <40.00%> (-1.59%) ⬇️
...rc/smart_markers/mod_smart_markers_rdbms_async.erl 85.18% <0.00%> (-3.71%) ⬇️
src/pubsub/node_pep.erl 79.62% <0.00%> (-1.86%) ⬇️
src/ejabberd_c2s.erl 88.94% <0.00%> (-0.23%) ⬇️
src/pubsub/mod_pubsub.erl 73.42% <0.00%> (-0.07%) ⬇️
src/mod_muc_room.erl 76.70% <0.00%> (+0.11%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.86% <0.00%> (+0.25%) ⬆️
src/pubsub/node_flat.erl 75.00% <0.00%> (+0.39%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.71% <0.00%> (+0.57%) ⬆️
src/rdbms/mongoose_rdbms.erl 67.01% <0.00%> (+0.70%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a83e02...0a9296f. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 3, 2022 •
edited
Loading

small_tests_24 / small_tests / 0a9296f
Reports root / small

small_tests_23 / small_tests / 0a9296f
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0a9296f
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0a9296f
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 0a9296f
Reports root/ big
OK: 2890 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 0a9296f
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 0a9296f
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0a9296f
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 0a9296f
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 0a9296f
Reports root/ big
OK: 3281 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 0a9296f
Reports root/ big
OK: 3281 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 0a9296f
Reports root/ big
OK: 3286 / Failed: 2 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,{{badmatch,false},
    [{pubsub_tools,check_notification,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,509}]},
     {pubsub_tools,receive_notification,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,505}]},
     {pubsub_tools,receive_item_notification,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,303}]},
     {pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,373}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pep_SUITE:pep_tests:authorize_access_model 
{error,{{badmatch,false},
    [{pubsub_tools,check_notification,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,509}]},
     {pubsub_tools,receive_notification,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,505}]},
     {pubsub_tools,receive_item_notification,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,303}]},
     {pep_SUITE,'-authorize_access_model/1-fun-0-',2,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,356}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0a9296f
Reports root/ big
OK: 1900 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 0a9296f
Reports root/ big
OK: 3292 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1986@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1986@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"IpUz6owGhkz1ZLuEhEyZuQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 0a9296f
Reports root/ big
OK: 1743 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

Premwoik
Premwoik approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Premwoik Premwoik merged commit be86eab into master Jun 6, 2022
@Premwoik Premwoik deleted the fix_inbox_bin branch June 6, 2022 08:21
@Premwoik Premwoik added this to the 5.1.0 milestone Jun 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Premwoik Premwoik Premwoik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NelsonVides @mongoose-im @Premwoik