-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement broadcasts in async pools #3755
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3755 +/- ##
==========================================
+ Coverage 82.66% 82.71% +0.05%
==========================================
Files 529 529
Lines 33957 33970 +13
==========================================
+ Hits 28069 28097 +28
+ Misses 5888 5873 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There is two new interfaces: one simply broadcasts a new value given a key to all workers. The other, broadcasts new important data that should be aggregated to all available keys. This is useful if we need to modify whatever tasks are pending.
2419a42
to
8130597
Compare
small_tests_24 / small_tests / 8130597 small_tests_25 / small_tests / 8130597 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8130597 ldap_mnesia_24 / ldap_mnesia / 8130597 dynamic_domains_mysql_redis_25 / mysql_redis / 8130597 ldap_mnesia_25 / ldap_mnesia / 8130597 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8130597 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8130597 rest_client_SUITE:roster:add_and_remove_some_contacts_properly{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_add_and_remove_some_contacts_properly_2285@domain.example.com/res1">>,
escalus_tcp,<0.9321.2>,
[{event_manager,<0.9281.2>},
{server,<<"domain.example.com">>},
{username,
<<"bOb_add_and_remove_some_contacts_properly_2285">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9281.2>},
{server,<<"domain.example.com">>},
{username,
<<"bOb_add_and_remove_some_contacts_properly_2285">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"bob_add_and_remove_some_contacts_properly_2285">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"bOb_add_and_remove_some_contacts_properly_2285">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"7ac04e402fd57291">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{rest_client_SUITE,add_contact_check_roster_push,2,
[{file,
"/home/circleci/project/big_te... pgsql_mnesia_24 / pgsql_mnesia / 8130597 internal_mnesia_25 / internal_mnesia / 8130597 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8130597 pgsql_mnesia_25 / pgsql_mnesia / 8130597 mysql_redis_25 / mysql_redis / 8130597 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2232@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2232@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"ZlATXmdu6WuCowBp6Bn+fg==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / 8130597 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} push_integration_SUITE:pubsub_ful:pm_notifications_with_inbox:inbox_msg_unread_count_fcm{error,
{{assertMatch,
[{module,push_integration_SUITE},
{line,662},
{expression,"Data"},
{pattern,"# { << \"message-count\" >> := ExpectedCount }"},
{value,
#{<<"last-message-body">> => <<"Private message">>,
<<"last-message-sender">> =>
<<"alice_inbox_msg_unread_count_fcm_2587@localhost">>,
<<"message-count">> => 1}}]},
[{push_integration_SUITE,check_notification,2,
[{file,
"/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
{line,662}]},
{push_integration_SUITE,'-inbox_msg_unread_count/3-fun-0-',6,
[{file,
"/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
{line,578}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} riak_mnesia_24 / riak_mnesia / 8130597 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8130597 mssql_mnesia_25 / odbc_mssql_mnesia / 8130597 |
Might be useful for telling all workers about a certain event.