Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

put reporter init after app startup #4085

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Aug 7, 2023

Fixes MIM-1989

How to verify:

  • Set a graphite node running, otherwise exometer_repert_graphite will crash.
  • On a running node, execute in the shell exometer_report:list_subscriptions(exometer_report_graphite).
    • On master, we will not find totalSessionCount available
    • In this branch it is there, similarly for all the other missing metrics.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (4433414) 83.90% compared to head (9b757d6) 83.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4085      +/-   ##
==========================================
- Coverage   83.90%   83.89%   -0.02%     
==========================================
  Files         527      527              
  Lines       33158    33158              
==========================================
- Hits        27822    27817       -5     
- Misses       5336     5341       +5     
Files Changed Coverage Δ
src/metrics/mongoose_metrics.erl 92.92% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides force-pushed the metrics/put_reporter_init_after_app_startup branch from 2156120 to 9b757d6 Compare August 7, 2023 19:51
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 7, 2023

small_tests_24 / small_tests / 9b757d6
Reports root / small


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 9b757d6
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 9b757d6
Reports root / small


small_tests_25_arm64 / small_tests / 9b757d6
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 9b757d6
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9b757d6
Reports root/ big
OK: 4221 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 9b757d6
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 9b757d6
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 9b757d6
Reports root/ big
OK: 4604 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9b757d6
Reports root/ big
OK: 4221 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 9b757d6
Reports root/ big
OK: 4218 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 9b757d6
Reports root/ big
OK: 4590 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 9b757d6
Reports root/ big
OK: 4604 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 9b757d6
Reports root/ big
OK: 2404 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 9b757d6
Reports root/ big
OK: 4601 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@NelsonVides NelsonVides marked this pull request as ready for review August 7, 2023 20:43
@NelsonVides NelsonVides requested a review from chrzaszcz August 7, 2023 20:44
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this 👍

@chrzaszcz chrzaszcz merged commit 97fd327 into master Aug 8, 2023
@chrzaszcz chrzaszcz deleted the metrics/put_reporter_init_after_app_startup branch August 8, 2023 06:07
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants