Skip to content

Breaking: Add fixer-return to rules preset #199

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

bmish
Copy link
Member

@bmish bmish commented Oct 3, 2021

All rules should have a category of either Rules or Tests since this is how those presets are generated.

Technically, this isn't a breaking change, since we're allowed to modify these presets any time, according to the README:

The list of recommended rules will only change in a major release of this plugin. However, new non-recommended rules might be added in a minor release of this plugin. Therefore, the using the all, rules, and tests presets is not recommended for production use, because the addition of new rules in a minor release could break your build.

Part of v4 release (#120).

All rules should have a category of either `Rules` or `Tests` since this is how those presets are generated.
@bmish bmish mentioned this pull request Oct 3, 2021
20 tasks
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aladdin-add aladdin-add merged commit 7cac82a into eslint-community:master Oct 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants