Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Breaking: Drop support for old minor versions of Node 12 and 14 #212

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Oct 13, 2021

This matches ESLint's Node version support. It sets us up for:

  • Using pure ESM dependencies (which are quickly becoming commonplace)
  • Converting this package to ESM (see Sindre's post)
  • Using other new Node features like node: prefix imports

Especially because this plugin is a dev-dependency for consumers, we can be more aggressive/strict here.

Originally discussed here: #151 (comment)

Part of v4 release (#120).

@aladdin-add
Copy link
Contributor

not to against the change, just to clarify:

  1. Sindre's packages require "node>=12". e.g. sindresorhus/is-unicode-supported@30ba81f#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R16
  2. if no build process, converting to esm is a breaking change, even it requires "node >=12.22.0" (esm cannot be required).

@aladdin-add aladdin-add merged commit 5604516 into eslint-community:master Oct 14, 2021
@bmish
Copy link
Member Author

bmish commented Oct 14, 2021

@aladdin-add Good points. Still, I think this PR is a worthwhile change.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants