Skip to content

feat!: capitalize default pattern of require-meta-docs-description rule #495

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Nov 17, 2024

@azat-io azat-io force-pushed the feat/capitalize-description branch from 1fa99c4 to ecaf037 Compare November 17, 2024 22:39
@azat-io azat-io changed the title feat: capitalize default pattern of rule feat: capitalize default pattern of require-meta-docs-description rule Nov 17, 2024
@aladdin-add aladdin-add changed the title feat: capitalize default pattern of require-meta-docs-description rule feat!: capitalize default pattern of require-meta-docs-description rule Nov 18, 2024
@aladdin-add
Copy link
Contributor

👍 I support it. However this is a breaking change, we'll have to wait until the next major release to consider it. / @bmish

@aladdin-add aladdin-add force-pushed the feat/capitalize-description branch from ecaf037 to 4dc9a43 Compare November 18, 2024 03:58
@bmish bmish added the BREAKING CHANGE This change will require a major version bump label Nov 18, 2024
@bmish
Copy link
Member

bmish commented Nov 18, 2024

If most of the top plugins use sentence case, then I'd be open to this.

For context, I found the PR where ESLint switched over to sentence case descriptions:

@aladdin-add aladdin-add force-pushed the feat/capitalize-description branch from 4dc9a43 to 914d12c Compare December 2, 2024 06:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants