Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Support ESLint 7.x #190

Merged
merged 1 commit into from
Apr 9, 2021
Merged

feat: Support ESLint 7.x #190

merged 1 commit into from
Apr 9, 2021

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented May 17, 2020

@kentcdodds
Copy link

Thanks for this @MichaelDeBoey!

Hi @xjamundx 👋👋👋

@MichaelDeBoey
Copy link
Member Author

@kentcdodds We still have to wait for eslint-plugin-eslint-plugin (eslint-community/eslint-plugin-eslint-plugin#95), eslint-plugin-node (mysticatea/eslint-plugin-node#224) & jest-runner-eslint (jest-community/jest-runner-eslint#92) before we can merge this one

@xjamundx
Copy link
Contributor

xjamundx commented Jul 8, 2020

Let me know when this is ready and I can review. I've mostly abandoned this project, but I can get this in.

@kentcdodds
Copy link

Thanks @xjamundx!

With almost 500k projects relying on this module, perhaps it would be good to find another maintainer?

image

@xjamundx
Copy link
Contributor

xjamundx commented Jul 8, 2020

@kentcdodds 😱

@xjamundx
Copy link
Contributor

xjamundx commented Jul 8, 2020

@MichaelDeBoey feel free to remove any dev deps causing issues. We'll probably publish this as a breaking change anyhow.

@MichaelDeBoey
Copy link
Member Author

@xjamundx We still have to wait for eslint-plugin-eslint-plugin (eslint-community/eslint-plugin-eslint-plugin#95) & eslint-plugin-node (mysticatea/eslint-plugin-node#224), which are both waiting for eslint-utils (mysticatea/eslint-utils#7) before we can merge this one

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review April 8, 2021 11:05
@MichaelDeBoey MichaelDeBoey changed the base branch from master to development April 8, 2021 11:19
@MichaelDeBoey
Copy link
Member Author

@xjamundx This one can be merged if you want to

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x
@xjamundx xjamundx merged commit 462a3b2 into eslint-community:development Apr 9, 2021
@xjamundx
Copy link
Contributor

xjamundx commented Apr 9, 2021

Publish as a breaking change?

@MichaelDeBoey
Copy link
Member Author

@xjamundx This is indeed a breaking change

@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch April 9, 2021 19:16
@xjamundx
Copy link
Contributor

xjamundx commented Apr 9, 2021

+ eslint-plugin-promise@5.0.0

@brettz9 brettz9 mentioned this pull request Apr 9, 2021
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
3 participants