Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: Bump all packages and fix linting #471

Closed
wants to merge 4 commits into from

Conversation

scagood
Copy link
Contributor

@scagood scagood commented May 27, 2024

Larger Changes

  1. Drop support for node less than ^18.18.0 (this is inline with eslint package.json:180)
  2. Drop support for eslint less than ^7.0.0

Smaller Changes

  1. Migrate all message to messageId (for the update to eslint-plugin-eslint-plugin)
  2. Bumped all packages (except eslint) to the latest version.
  3. Replaced eslint-plugin-node with eslint-plugin-n
  4. Replaced npm-run-all with npm-run-all2

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (4db7f5d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       653    +4     
  Branches       250       246    -4     
=========================================
+ Hits           649       653    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scagood scagood force-pushed the bump-dependencies branch from ba2c1f8 to 75e107b Compare May 27, 2024 12:19
@scagood scagood force-pushed the bump-dependencies branch from 75e107b to 4db7f5d Compare May 27, 2024 12:22
@scagood scagood marked this pull request as ready for review May 27, 2024 12:34
@scagood
Copy link
Contributor Author

scagood commented May 27, 2024

@aladdin-add
Copy link
Contributor

this is a breaking change.

@aladdin-add aladdin-add changed the title feat: Bump all packages and fix linting feat!: Bump all packages and fix linting May 28, 2024
@scagood
Copy link
Contributor Author

scagood commented May 28, 2024

this is a breaking change.

The commits here are meant to be rebase merged, but its good that the title is representative of that too 😄

@aladdin-add
Copy link
Contributor

aladdin-add commented May 28, 2024

what do you think splitting the PR to several smaller ones, for clearer changelogs?

@scagood
Copy link
Contributor Author

scagood commented May 28, 2024

The only one I would split out would be 9dcfd39 (#471)

However if that is the only way to convert the commits to changelog entries, I will split them into 4.

@aladdin-add
Copy link
Contributor

I suggest splitting 4db7f5d and fc861bf to one - they introduced breaking changes.

@brettz9 brettz9 requested review from brettz9 and removed request for brettz9 July 6, 2024 09:08
@brettz9
Copy link
Member

brettz9 commented Jul 13, 2024

@scagood : if you want to resolve the conflicts and split out the changes, I'd be happy to do a review. Also, can team members do merges if for another's PR, or is the merging reserved for team leaders?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants