Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for eslint v9 #478

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat: add support for eslint v9 #478

merged 2 commits into from
Jul 1, 2024

Conversation

ota-meshi
Copy link
Member

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)

This PR changes the no-multiple-resolved rule to work with eslint v9.

Fixes #472
Follow up for #466

@ota-meshi ota-meshi requested a review from a team June 21, 2024 12:34
@ota-meshi ota-meshi mentioned this pull request Jun 21, 2024
6 tasks
@brettz9
Copy link
Member

brettz9 commented Jun 30, 2024

Is there a community process requiring a review here, or as an owner, can you just merge, @ota-meshi ?

Eager to see progress on these PRs to support ESLint 9 and flat config...

@ota-meshi
Copy link
Member Author

Hi @brettz9
The requirement for merging a PR is that it needs to be reviewed by someone on our team.
I think you can review this PR and it will meet the requirements for merging.
Or can you merge this PR? There aren't many active members on eslint-plugin-promise right now.

@brettz9
Copy link
Member

brettz9 commented Jul 1, 2024

As I'm not a member of the team, I think someone on the core team like yourself would need to nominate me to join the team as per https://github.com/eslint-community/governance/blob/51dc45a2177827d26d9a15f458843a8c4979fddd/GOVERNANCE.md?plain=1#L134 .

It looks like you need to open a private team discussion on GitHub about adding me and get the votes of the core team and eslint-plugin-promise team members.

My most relevant contributions are probably those on eslint-plugin-promise itself (just a few) and on eslint-plugin-jsdoc.

@ota-meshi ota-meshi requested a review from a team July 1, 2024 01:13
@aladdin-add aladdin-add merged commit 4dfc8a7 into main Jul 1, 2024
17 checks passed
@aladdin-add aladdin-add deleted the eslint-v9 branch July 1, 2024 01:51
Copy link
Contributor

github-actions bot commented Jul 1, 2024

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-multiple-resolved rule in ESLint 9.3.0: TypeError: Cannot read properties of undefined (reading 'map')
3 participants